Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stream car file bytes from @helia/car #444

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Conversation

achingbrain
Copy link
Member

To better support streaming CAR files with a less confusing API, add a method to @helia/car that takes root CIDs and returns an AsyncGenerator that yields CAR file bytes.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

To better support streaming CAR files with a less confusing API,
add a method to `@helia/car` that takes root CIDs and returns an
AsyncGenerator that yields CAR file bytes.
@achingbrain achingbrain requested a review from a team as a code owner February 21, 2024 16:21
@achingbrain achingbrain changed the title Feat/stream car files feat: stream car file bytes from @helia/car Feb 21, 2024
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

packages/car/src/index.ts Outdated Show resolved Hide resolved
packages/car/src/index.ts Outdated Show resolved Hide resolved
packages/car/src/index.ts Outdated Show resolved Hide resolved
packages/car/src/index.ts Outdated Show resolved Hide resolved
packages/car/src/index.ts Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 7c07e11 into main Feb 21, 2024
18 checks passed
@achingbrain achingbrain deleted the feat/stream-car-files branch February 21, 2024 18:19
@achingbrain achingbrain mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants